feat: add driver support for experimental host #724
Conversation
Summary of ChangesHello @sagnghos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for connecting to an experimental Spanner host, including plaintext, TLS, and mTLS connections. The changes are well-structured and include corresponding integration tests. I've identified a couple of areas for improvement, mainly around improving the robustness of the mTLS configuration and reducing code duplication in the integration tests. Overall, this is a solid contribution.
| // - rpcPriority: Sets the priority for all RPC invocations from this connection (HIGH/MEDIUM/LOW). The default is HIGH. | ||
| // | ||
| // Example: `localhost:9010/projects/test-project/instances/test-instance/databases/test-database;usePlainText=true;disableRouteToLeader=true;enableEndToEndTracing=true` | ||
| var dsnRegExp = regexp.MustCompile(`((?P<HOSTGROUP>[\w.-]+(?:\.[\w\.-]+)*[\w\-\._~:/?#\[\]@!\$&'\(\)\*\+,;=.]+)/)?projects/(?P<PROJECTGROUP>(([a-z]|[-.:]|[0-9])+|(DEFAULT_PROJECT_ID)))(/instances/(?P<INSTANCEGROUP>([a-z]|[-]|[0-9])+)(/databases/(?P<DATABASEGROUP>([a-z]|[-]|[_]|[0-9])+))?)?(([\?|;])(?P<PARAMSGROUP>.*))?`) |
There was a problem hiding this comment.
The Python wrapper tests are failing, and I think that is related to the changes here. It seems like there are some changes to HOSTGROUP. Are those intentional?
Also, the regex now has a ^ and $, which would (probably) disallow leading/trailing spaces, which could be the reason.
There was a problem hiding this comment.
Yes the change to HOSTGROUP was intentional. Otherwise it was capturing /databases in the host group itself after projects and instances were made optional
As for the error you are kind of correct. I think the spannerlib-python is buggy. The setup was generating the url as localhost:9010projects/test-project/.... But since the ^ and $ was not there the absence of "/" between localhost:9010 and projects didn't raise a error. Now its catching it. I have made the change in the test setup itself. Let me know if you have other suggestions.
3 participants
Add support for connection to experimental host using the go-sql-spanner driver
The driver should be able to connect to a Spanner experimental host endpoint using:
The integration tests have been modified to test the above scenarios against experimental host setup